Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Add label_translation_parameters, help_translation_parameters and attr_translation_parameters options to base form type#28635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Form] Add label_translation_parameters, help_translation_parameters and attr_translation_parameters options to base form type#28635
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedSep 29, 2018
that's the point of the PR, ensuring components are still compatible with each others versions listed in composer.json files. This should be fixed. |
ro0NL commentedSep 29, 2018
At some point i'd really like to see a A single value could simplify things a lot: 'label' =>'text','other_label' =>newTranslation('text','domain', ['param' =>'value'],'nl_NL'),'other_other_label' =>newIdentityTranslation('text'), |
webnet-fr commentedOct 1, 2018
@nicolas-grekas, travis CI is actually green when On the other hand with |
webnet-fr commentedOct 1, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@ro0NL. There is always a way to acheive desired result in Symfony, that's why we love it :) 'other_label' =>newTranslation('text','domain', ['param' =>'value'],$request->getLocale()), |
ro0NL commentedOct 1, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Those would be all nullable (except $text), as its purpose would be to override defaults |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
xabbuh commentedOct 1, 2018
@webnet-fr Those tests ensure that Symfony 4.1 components will work with dependencies in version 4.2. This is a bit hard for the form theme tests though as they almost do 1:1 comparisons of the generated HTML. We also struggle with that in#27043 for example. So we need to look how we can relax assertions in 4.1 a bit to reduce the pain here. |
webnet-fr commentedOct 4, 2018
soullivaneuh commentedDec 10, 2018
Well even if I'm sure of my review, I'm less sure@carsonbot should listen to me. 😉 |
xabbuh commentedFeb 8, 2019
The |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The changes look good to me.
@webnet-fr Can you add an entry to the changelog file of the Form component to mention the new options?
webnet-fr commentedFeb 10, 2019
@xabbuh I've updated changelog. I will correct documentation PR shortly. |
webnet-fr commentedFeb 12, 2019
Documentation is updted.symfony/symfony-docs#10065 |
…and attr_translation_parameters options to base form type
fabpot commentedFeb 13, 2019
Thank you@webnet-fr. |
…ion_parameters and attr_translation_parameters options to base form type (webnet-fr)This PR was squashed before being merged into the 4.3-dev branch (closes#28635).Discussion----------[Form] Add label_translation_parameters, help_translation_parameters and attr_translation_parameters options to base form type| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes. Travis-ci isn't green because it tests the components separately. Fabbot.io requires license headers in files where they were not present before.| Fixed tickets |#27698| License | MIT| Doc PR |symfony/symfony-docs#10065Hi, this is an alternative to#27775.`translation_parameters` is separated to `label_translation_parameters`, `help_translation_parameters`, `attr_translation_parameters`.Commits-------b3f3c53 [Form] Add label_translation_parameters, help_translation_parameters and attr_translation_parameters options to base form type
…dyslav Riabchenko)This PR was merged into the master branch.Discussion----------[Form] New translation_parameters optionDocumentingsymfony/symfony#28635Commits-------20c6f5a correct arrays short syntax70f36ad correct bugd7e7b0b correct attr link in entity type doc71fc7ce typo in form_translation_parameters docsa655106 confirm with 2863532e79e1 correct link errorc57d30a new translation_parameters form option
MihaiBwr commentedFeb 5, 2020
How can I make this raw? Does not seem to be such an option. the html_help => true does not help in this situation. Thanks. |
Uh oh!
There was an error while loading.Please reload this page.
Hi, this is an alternative to#27775.
translation_parametersis separated tolabel_translation_parameters,help_translation_parameters,attr_translation_parameters.