Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] marked getFallbackLocales() as internal#28626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for starting this. Would you mind having a look at where this method is used in the code base and remove/replace them?
CHANGELOG-4.1.md Outdated
| * 4.1.4 (2018-08-28) | ||
| * deprecation#28579[Translator] set the getFallbackLocales() method as deprecated (boscho87) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This file is autogenerated so all changes should be reverted. But the changelog in the component itself should be updated instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thus, a PR to master would not change the existing 4.1.4 release
Uh oh!
There was an error while loading.Please reload this page.
stof left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The file mode change on the different php files must be reverted too.
If you are on Windows, here is the way to go:
# configure git to avoid doing such mess in the futuregit config --global core.fileModefalse# change the mode back for these filesgit update-index --chmod=-x path/to/file.ext
Uh oh!
There was an error while loading.Please reload this page.
| */ | ||
| publicfunctiongetFallbackLocales() | ||
| { | ||
| @trigger_error('getFallbackLocales() is deprecated since version 4.1 and will be removed in 5.0.',E_USER_DEPRECATED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
deprecation is in 4.2, not in 4.1. We cannot deprecate it in 4.1 as it is already released since 4 months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@stof tahnk you for your effort to teaching me! (i will work on this tomorrow 👍 )
boscho87 commentedSep 28, 2018
@nicolas-grekas i do not find any usages... |
nicolas-grekas commentedSep 29, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Running |
boscho87 commentedSep 29, 2018
Idk i never before had such problems with changing file permisssions |
CHANGELOG-4.1.md Outdated
| * feature#25605[PropertyInfo] Added support for extracting type from constructor (lyrixx) | ||
| * feature#24763[Process] Allow writing portable "prepared" command lines (Simperfit) | ||
| * feature#25218[Serializer] add a constructorarguement to return csv always as collection (Simperfit) | ||
| * feature#25218[Serializer] add a constructorargument to return csv always as collection (Simperfit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The changes in this file should be reverted as it is auto-generated.
boscho87 commentedSep 30, 2018
Maybe i should not have started this PR... im a bit confused what is need to be done exactly.. e.ghttps://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php#L321 here ... should this whole method all so be removed and all the stuff who uses tha catalouges toohttps://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php#L200 |
nicolas-grekas commentedSep 30, 2018
I think there is an easy way to finish this PR, which is reverting the deprecation and add |
fabpot commentedOct 3, 2018
Thank you@boscho87. |
…(boscho87)This PR was merged into the 4.2-dev branch.Discussion----------[Translation] marked getFallbackLocales() as internal| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#28579| License | MIT| Doc PR |Added the deprication trigger error function to getFallbackLocales in the Translation component.(Its my first PR, please tell me if i need to change something)Commits-------9d67a68 [Translation] marked getFallbackLocales() as internal
boscho87 commentedOct 3, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fabpot@nicolas-grekas Was a small one but my first Hope i can do „bigger things“ in the future |
This PR was merged into the 4.2 branch.Discussion----------Drop spurious execution bit| Q | A| ------------- | ---| Branch? | 4.2 for bug fixes| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | noneThe execution bit seems to have been added by mistake in#28626.Commits-------93dab5c Drop spurious execution bit
Uh oh!
There was an error while loading.Please reload this page.
Added the deprication trigger error function to getFallbackLocales in the Translation component.
(Its my first PR, please tell me if i need to change something)