Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Finder] fixed root directory access for ftp/sftp wrapper#28604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromDerDu:issue_27423
Oct 3, 2018

Conversation

@DerDu
Copy link
Contributor

@DerDuDerDu commentedSep 26, 2018
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27423
LicenseMIT
Doc PRsymfony/symfony-docs#...

This fixes a flaw introduced in 3.4.7 by#26763

In order to access the root folder with ftp wrapper, there MUST BE a slash present.

  • Currently: from 3.4.7 on it justrtrim all seperators (/,\) from directories
  • Now: IF the directory is a (s)ftp:// wrapper (#^s?ftp://#) this fix just adds a slash (/) again

@fabpot
Copy link
Member

Thank you@DerDu.

@fabpotfabpot merged commit9630a38 intosymfony:3.4Oct 3, 2018
fabpot added a commit that referenced this pull requestOct 3, 2018
…(DerDu)This PR was squashed before being merged into the 3.4 branch (closes#28604).Discussion----------[Finder] fixed root directory access for ftp/sftp wrapper| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27423| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->This fixes a flaw introduced in 3.4.7 by#26763In order to access the root folder with ftp wrapper, there MUST BE a slash present.- Currently: from 3.4.7 on it just ```rtrim``` all seperators (```/```, ```\```) from directories- Now: IF the directory is a (s)ftp:// wrapper (```#^s?ftp://#```) this fix just adds a slash (```/```) againCommits-------9630a38 [Finder] fixed root directory access for ftp/sftp wrapper
This was referencedOct 3, 2018
fabpot added a commit that referenced this pull requestNov 15, 2019
This PR was merged into the 3.4 branch.Discussion----------[Finder] Allow ssh2 stream wrapper for sftpSame fix as#28604 but for the ssh2.sftp wrapper.| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#28604 maybe| License       | MIT| Doc PR        |Without this patch, we can't use the finder with ssh2.sftp connections.```php$connection = \ssh2_connect('host', 22);\ssh2_auth_password($connection, 'user', 'pass');$sftp = \ssh2_sftp($connection);$path = "ssh2.sftp://".intval($sftp)."/";$finder = new Finder();foreach ($finder->in($path)->files() as $directory) {    dump(file_get_contents($directory));}```Without the patch:>   RecursiveDirectoryIterator::__construct(ssh2.sftp://838): failed to open dir: operation failedCommits-------e6c9d77 [Finder] Allow ssh2 stream wrapper for sftp
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@DerDu@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp