Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] add casters for IntlDateFormatter and IntlCalendar#28566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jschaedl
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28554
LicenseMIT
Doc PR-

}

$a +=array(
Caster::PREFIX_VIRTUAL.'time_zone' =>$c->getTimeZone(),
Copy link
Member

@nicolas-grekasnicolas-grekasSep 23, 2018•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you're going to be an expert in writing casters :)
here, I'd suggest removing the previous "if" and replace it with this in the big array above:
Caster::PREFIX_VIRTUAL.'time_zone' => ($filter & Caster::EXCLUDE_VERBOSE) ? new CutStub($c->getTimeZone()) : $c->getTimeZone()
(same below)

jschaedl reacted with thumbs up emoji
@jschaedljschaedlforce-pushed thevd-caster-intl_date_formatter branch fromf004d68 to8bf4816CompareSeptember 23, 2018 16:09
@nicolas-grekasnicolas-grekasforce-pushed thevd-caster-intl_date_formatter branch from8bf4816 toae76c68CompareSeptember 23, 2018 16:25
@nicolas-grekas
Copy link
Member

Thank you@jschaedl.

@nicolas-grekasnicolas-grekas merged commitae76c68 intosymfony:masterSep 23, 2018
nicolas-grekas added a commit that referenced this pull requestSep 23, 2018
…Calendar (jschaedl)This PR was squashed before being merged into the 4.2-dev branch (closes#28566).Discussion----------[VarDumper] add casters for IntlDateFormatter and IntlCalendar| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28554| License       | MIT| Doc PR        | -Commits-------ae76c68 [VarDumper] add casters for IntlDateFormatter and IntlCalendar
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
@jschaedljschaedl deleted the vd-caster-intl_date_formatter branchFebruary 23, 2020 08:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jschaedl@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp