Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[VarDumper] add caster for IntlTimeZone#28559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jschaedl commentedSep 22, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28554 |
| License | MIT |
| Doc PR | - |
nicolas-grekas commentedSep 23, 2018
should we add dump getDSTSavings only when useDaylightTime is true? |
nicolas-grekas commentedSep 23, 2018
can be rebased now that#28555 is merged (and thus can leverage castError) |
jschaedl commentedSep 23, 2018
on it |
091f70c to02d4212Compare| publicfunctiontestCastIntlTimeZoneWithDST() | ||
| { | ||
| $var = \IntlTimeZone::createTimeZone('Europe/Berlin'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't we take another TZ, since we know Europe is going to give up DST next year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes sure, I totally forgot about that.
07c00af toc94217cComparenicolas-grekas commentedSep 23, 2018
Thank you@jschaedl. |
This PR was squashed before being merged into the 4.2-dev branch (closes#28559).Discussion----------[VarDumper] add caster for IntlTimeZone| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28554| License | MIT| Doc PR | -Commits-------c94217c [VarDumper] add caster for IntlTimeZone