Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] fix disabling DeprecationErrorHandler using phpunit.xml file#28524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| && DeprecationErrorHandler::MODE_WEAK !==$mode | ||
| && DeprecationErrorHandler::MODE_WEAK_VENDORS !==$mode | ||
| && (!isset($mode[0]) ||'/' !==$mode[0]) | ||
| ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
indentation should be one level down here
| $mode =getenv('SYMFONY_DEPRECATIONS_HELPER'); | ||
| } | ||
| if (DeprecationErrorHandler::MODE_WEAK !==$mode && DeprecationErrorHandler::MODE_WEAK_VENDORS !==$mode && (!isset($mode[0]) ||'/' !==$mode[0])) { | ||
| if (DeprecationErrorHandler::MODE_DISABLED !==$mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please remove trailing spaces (see fabbot failure)
nicolas-grekas commentedSep 20, 2018
@soerenbernstein I suppose you confirm this fixes the issue and allows disabling the bridge using the phpunit.xml file? |
soerenbernstein commentedSep 20, 2018
Yes. And it will actually set the mode to "disabled" forfuture use. |
nicolas-grekas commentedSep 20, 2018
Thank you@soerenbernstein. |
…g phpunit.xml file (soerenbernstein)This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes#28524).Discussion----------[PhpUnitBridge] fix disabling DeprecationErrorHandler using phpunit.xml fileFixing#28519| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | don't know| Fixed tickets |#28519| License | MITCommits-------3cd929b [PhpUnitBridge] fix disabling DeprecationErrorHandler using phpunit.xml file
Fixing#28519