Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Translation] Added support for multiple files or directories in XliffLintCommand#28522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6c9dacb tod329ebeCompare| "symfony/serializer":"<4.1", | ||
| "symfony/stopwatch":"<3.4", | ||
| "symfony/translation":"<4.2", | ||
| "symfony/translation":"<=4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't look right to me as it would actually mean that when 4.2 is released we wouldn't be able to use FrameworkBundle with any stable release of the Translation component then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can just revert all the changes for this file (it's okay if thedeps=high build fails in this case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it's okay if the deps=high build fails in this case
Actually no, it's not OK on master: a deps=high failure on master means 4.1 will break with the change when using 4.2 deps.
But yes! the composer.json changes must be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Reverted, butdeps=high will fails, not sure how to solve it :( I tried how far I could, so I need help here.
- Installing symfony/translation (4.2.x-dev): Downloading (100%)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Proposal to patch 4.1 in#28525
src/Symfony/Bundle/FrameworkBundle/Tests/Command/XliffLintCommandTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
d329ebe to64df255Compared0d4184 to88ec37bComparenicolas-grekas commentedSep 21, 2018
Thank you@yceruto. |
…ctories in XliffLintCommand (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes#28522).Discussion----------[Translation] Added support for multiple files or directories in XliffLintCommand| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#10368Same approach of#28521Commits-------88ec37b [Translation] Added support for multiple files or directories in XliffLintCommand
…ories in XliffLintCommand (yceruto, javiereguiluz)This PR was merged into the master branch.Discussion----------[Translation] Added support for multiple files or directories in XliffLintCommandSeesymfony/symfony#28522Commits-------e4494bd Added the versionadded directivee68d242 typo5657303 Added support for multiple files or directories
Uh oh!
There was an error while loading.Please reload this page.
Same approach of#28521