Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] Added support for multiple files or directories in LintCommand#28521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromyceruto:lint-yaml-cmd-feat
Sep 21, 2018

Conversation

@yceruto
Copy link
Member

@ycerutoyceruto commentedSep 19, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28498
LicenseMIT
Doc PRsymfony/symfony-docs#10367

"symfony/validator":"<4.1",
"symfony/workflow":"<4.1"
"symfony/workflow":"<4.1",
"symfony/yaml":"<=4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

<4.2

nicolas-grekas reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done, but still:

  • Installing symfony/yaml (4.2.x-dev): Downloading (100%)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

which mean it worked actually

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is the fails before the last commithttps://travis-ci.org/symfony/symfony/jobs/430972569#L2994

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedSep 20, 2018•
edited
Loading

On master, deps=high failures mean the PR breaks 4.1 when used with deps at 4.2 - this should be fixed somehow (yes, that's the big downside of moving things to components: we now have to deal with cross deps compat...)

xabbuh and sroze reacted with thumbs up emoji

@stof
Copy link
Member

Well, here, the issue is only related to the way our CommandTester works. Turning an argument into an array argument is a BC break for tests, because the argument now has to be provided as an array, while there is no BC break when running the command in the CLI.

And as FrameworkBundle extends the command and has tests for its child class, it is affected by this change in the argument definition of the component.

@yceruto
Copy link
MemberAuthor

Could be an alternative to do this in the command$filenames = (array) $input->getArgument('filename'); and revert all changes in tests?

@chalasr
Copy link
Member

@yceruto you mean reverting the argument type toOPTIONAL and parsing$filenames in the command itself? I don't think it's a good alternative

@chalasrchalasr added this to thenext milestoneSep 20, 2018
@ycerutoycerutoforce-pushed thelint-yaml-cmd-feat branch 2 times, most recently from4ef5274 to11a6498CompareSeptember 20, 2018 12:26
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

got it :)

symfony-splitter pushed a commit to symfony/translation that referenced this pull requestSep 21, 2018
…ctories in XliffLintCommand (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes #28522).Discussion----------[Translation] Added support for multiple files or directories in XliffLintCommand| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        |symfony/symfony-docs#10368Same approach ofsymfony/symfony#28521Commits-------88ec37bed7 [Translation] Added support for multiple files or directories in XliffLintCommand
nicolas-grekas added a commit that referenced this pull requestSep 21, 2018
…ctories in XliffLintCommand (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes#28522).Discussion----------[Translation] Added support for multiple files or directories in XliffLintCommand| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        |symfony/symfony-docs#10368Same approach of#28521Commits-------88ec37b [Translation] Added support for multiple files or directories in XliffLintCommand
@nicolas-grekas
Copy link
Member

Thank you@yceruto.

@nicolas-grekasnicolas-grekas merged commitd0f7950 intosymfony:masterSep 21, 2018
nicolas-grekas added a commit that referenced this pull requestSep 21, 2018
… in LintCommand (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes#28521).Discussion----------[Yaml] Added support for multiple files or directories in LintCommand| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28498| License       | MIT| Doc PR        |symfony/symfony-docs#10367Commits-------d0f7950 [Yaml] Added support for multiple files or directories in LintCommand
@ycerutoyceruto deleted the lint-yaml-cmd-feat branchSeptember 21, 2018 11:06
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestSep 21, 2018
…ries (yceruto, javiereguiluz)This PR was merged into the master branch.Discussion----------[Yaml] Documenting support for multiple files or directoriesSeesymfony/symfony#28521Commits-------23f6465 Added the versionadded directive6cf8bef typoa5546a6 adding missing "or"1513f22 Added support for multiple files or directories
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
SerhiyMytrovtsiy added a commit to SerhiyMytrovtsiy/translation that referenced this pull requestOct 19, 2022
…ctories in XliffLintCommand (yceruto)This PR was squashed before being merged into the 4.2-dev branch (closes #28522).Discussion----------[Translation] Added support for multiple files or directories in XliffLintCommand| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        |symfony/symfony-docs#10368Same approach ofsymfony/symfony#28521Commits-------88ec37bed7 [Translation] Added support for multiple files or directories in XliffLintCommand
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

7 participants

@yceruto@nicolas-grekas@stof@chalasr@javiereguiluz@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp