Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Ignore backslashes in service ids when using debug:container and debug:autowiring#28487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:masterfromrespinoza:ignore-backslash-when-searching-serviceSep 19, 2018
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
20f37b3 to67763b5Comparenicolas-grekas approved these changesSep 17, 2018
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for submitting!
ContributorAuthor
respinoza commentedSep 17, 2018
@nicolas-grekas do we need a doc PR for this? |
Member
nicolas-grekas commentedSep 17, 2018
I'm not sure actually. |
chalasr approved these changesSep 17, 2018
| * Added new "auto" mode for`framework.session.cookie_secure` to turn it on when HTTPS is used | ||
| * Removed the`framework.messenger.encoder` and`framework.messenger.decoder` options. Use the`framework.messenger.serializer.id` option to replace the Messenger serializer. | ||
| * Deprecated the`ContainerAwareCommand` class in favor of`Symfony\Component\Console\Command\Command` | ||
| * Add the ability to ignore backslashes in service ids when using`debug:container` and`debug:autowiring` |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added :)
…:container` and `debug:autowiring`
67763b5 to0aba355CompareMember
nicolas-grekas commentedSep 19, 2018
Thank you@respinoza. |
nicolas-grekas added a commit that referenced this pull requestSep 19, 2018
…en using debug:container and debug:autowiring (respinoza)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] Ignore backslashes in service ids when using debug:container and debug:autowiring| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28143| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Commits-------0aba355 [FrameworkBundle] Ignore backslashes in service ids when using `debug:container` and `debug:autowiring`
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.