Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MonologBridge] Re-add option option to ignore empty context and extra data#28471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@mpdude
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

In#11496, an option was added toConsoleFormatter to ignore empty context and extra data. This setting was even turned on by default.

TheConsoleHandler was then overhauled in#21705. During this change, the option got lost.

@nicolas-grekas
Copy link
Member

New feature, isn't it?

@mpdude
Copy link
ContributorAuthor

@nicolas-grekas No, I’d say it restores a feature that was there before and accidentally got lost - see description.

@nicolas-grekasnicolas-grekasforce-pushed theignore-empty-context-and-extra branch from7565681 tod1e7438CompareSeptember 20, 2018 11:58
@nicolas-grekas
Copy link
Member

Thank you@mpdude.

@nicolas-grekasnicolas-grekas merged commitd1e7438 intosymfony:3.4Sep 20, 2018
nicolas-grekas added a commit that referenced this pull requestSep 20, 2018
…xt and extra data (mpdude)This PR was squashed before being merged into the 3.4 branch (closes#28471).Discussion----------[MonologBridge] Re-add option option to ignore empty context and extra data| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |In#11496, an option was added to `ConsoleFormatter` to ignore empty context and extra data. This setting was even turned on by default.The `ConsoleHandler` was then overhauled in#21705. During this change, the option got lost.Commits-------d1e7438 [MonologBridge] Re-add option option to ignore empty context and extra data
@nicolas-grekas
Copy link
Member

(would you mind checking where this would need to be mentioned in the doc please?)

@mpdude
Copy link
ContributorAuthor

@nicolas-grekas you mean the changelog or rather the symfony-docs?

@nicolas-grekas
Copy link
Member

The Symfony doc if possible.

mpdude reacted with thumbs up emoji

@mpdudempdude deleted the ignore-empty-context-and-extra branchSeptember 20, 2018 18:19
This was referencedSep 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mpdude@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp