Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form][TwigBridge] fix not displaying labels when value is false#28469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedSep 14, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28198 |
| License | MIT |
| Doc PR |
xabbuh commentedSep 15, 2018
| 'invalid_message_parameters', | ||
| ))); | ||
| if (false ===$options['label']) { |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change technically could go into the2.8 branch too. Though it would only fix custom form themes there. Our built-in form themes do not suffer from this issue in older branches.
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see#28508
HeahDude approved these changesSep 15, 2018
nicolas-grekas approved these changesSep 17, 2018
Member
nicolas-grekas commentedSep 18, 2018
Thank you@xabbuh. |
nicolas-grekas added a commit that referenced this pull requestSep 18, 2018
… false (xabbuh)This PR was merged into the 4.1 branch.Discussion----------[Form][TwigBridge] fix not displaying labels when value is false| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28198| License | MIT| Doc PR |Commits-------c4a6c9f fix not displaying labels when value is false
xabbuh added a commit to xabbuh/symfony that referenced this pull requestSep 19, 2018
This change does not fix any built-in Symfony form themes, but takesinto account the changes made insymfony#28469 to allow third-party form themeswork properly.
nicolas-grekas added a commit that referenced this pull requestSep 20, 2018
This PR was merged into the 2.8 branch.Discussion----------[Form] forward false label option to nested types| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28469 (comment)| License | MIT| Doc PR |This change does not fix any built-in Symfony form themes, but takesinto account the changes made in#28469 to allow third-party form themeswork properly.Commits-------3247cde forward false label option to nested types
symfony-splitter pushed a commit to symfony/form that referenced this pull requestSep 20, 2018
This PR was merged into the 2.8 branch.Discussion----------[Form] forward false label option to nested types| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#28469 (comment)| License | MIT| Doc PR |This change does not fix any built-in Symfony form themes, but takesinto account the changes made in #28469 to allow third-party form themeswork properly.Commits-------3247cdeea9 forward false label option to nested types
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.