Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Ldap] Add verbose ext-ldap error if present for easier debugging#28424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ba2d6f0 to0845126Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(with minor comment)
| if (false ===$this->search) { | ||
| thrownewLdapException(sprintf('Could not complete search with dn "%s", query "%s" and filters "%s".',$this->dn,$this->query,implode(',',$this->options['filter']))); | ||
| $ldapError =''; | ||
| if (0 !== ($errno =ldap_errno($con))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd suggest to write this asif ($errno = ldap_errno($con)) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hoped to find something likeLDAP_ERROR_NONE for better readability, but failed. Initial idea was
if (LDAP_ERROR_NONE !== ($errno = ldap_errno($con))) {Without that your suggestion looks better, indeed, I'll fix it
nicolas-grekas commentedSep 10, 2018
(to be merged on master actually as that's not a bug fix but an improvement.) |
scaytrase commentedSep 11, 2018
@nicolas-grekas should I rebase? |
nicolas-grekas commentedSep 11, 2018
@scaytrase if you can please yes, otherwise no worries we'll take care of it. |
scaytrase commentedSep 11, 2018
rebased |
nicolas-grekas commentedSep 21, 2018
Thank you@scaytrase. |
…r debugging (scaytrase)This PR was merged into the 4.2-dev branch.Discussion----------[Ldap] Add verbose ext-ldap error if present for easier debugging| Q | A| ------------- | ---| Branch? | master (be careful when merging)| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? || Fixed tickets |#28149| License | MIT| Doc PR |Added an optional message suffix if ldap_errno is not equals to 0Commits-------761415f Add verbose ext-ldap error if present for easier debugging
Uh oh!
There was an error while loading.Please reload this page.
Added an optional message suffix if ldap_errno is not equals to 0