Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] enable DebugClassLoader by default#28412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[PhpUnitBridge] enable DebugClassLoader by default#28412
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * | ||
| * @see http://tools.ietf.org/html/rfc2616#section-10.3.5 | ||
| * | ||
| * @final |
nicolas-grekasSep 9, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This method is extended inStreamedResponse, so it cannot be final.
nicolas-grekasSep 16, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed in favor of#28483
| Blacklist::$blacklistedClassNames['\Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerTrait'] =2; | ||
| } | ||
| $enableDebugClassLoader =\class_exists('Symfony\Component\Debug\DebugClassLoader'); |
nicolas-grekasSep 9, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(as a reminder, because we want to use it when testing branch 2.8, the bridge is still compatible with PHP 5.3, so we cannot use::class here)
GuilhemN left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's a great improvement 👍
2aa983e to2fb11fcCompare…colas-grekas)This PR was merged into the 4.2-dev branch.Discussion----------[PhpUnitBridge] enable DebugClassLoader by default| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#10360With this PR, the phpunit-bridge will enable `DebugClassLoader` by default, making it do its job: throw deprecation notices at autoloading time. On top of#28329, this made me spot some glitches in the code base, fixed here also.This can be disabled by configuring the listener in `phpunit.xml.dist` files, adding `<element key="debug-class-loader"><integer>0</integer></element>` next to `<element key="time-sensitive">...`.Commits-------2fb11fc [PhpUnitBridge] enable DebugClassLoader by default
Uh oh!
There was an error while loading.Please reload this page.
With this PR, the phpunit-bridge will enable
DebugClassLoaderby default, making it do its job: throw deprecation notices at autoloading time. On top of#28329, this made me spot some glitches in the code base, fixed here also.This can be disabled by configuring the listener in
phpunit.xml.distfiles, adding<element key="debug-class-loader"><integer>0</integer></element>next to<element key="time-sensitive">....