Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Controller][ServiceValueResolver] Making method access case insensitive#28404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromnicoweb:fix_28254
Sep 9, 2018

Conversation

@nicoweb
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28254
LicenseMIT
Doc PR-

Fix#28254 by making the method access insensitive inServiceValueResolver.

@ostrolucky
Copy link
Contributor

Does this handle older AppBundle:Blog:list notation (notice no:: in there)?

@nicolas-grekas
Copy link
Member

@ostrolucky the attached patch searches for only one: so it will work equally well with one or two:.
Also, I don't think the old notation ever hits theServiceValueResolver: it is resolved before.

ostrolucky and nicoweb reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@nicoweb.

@nicolas-grekasnicolas-grekas merged commitcc6f827 intosymfony:3.4Sep 9, 2018
nicolas-grekas added a commit that referenced this pull requestSep 9, 2018
…se insensitive (nicoweb)This PR was merged into the 3.4 branch.Discussion----------[Controller][ServiceValueResolver] Making method access case insensitive| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28254| License       | MIT| Doc PR        | -Fix#28254 by making the method access insensitive in `ServiceValueResolver`.Commits-------cc6f827 [Controller][ServiceValueResolver] Making method access case insensitive
@nicowebnicoweb deleted the fix_28254 branchSeptember 9, 2018 09:49
This was referencedSep 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nicoweb@ostrolucky@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp