Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Add a simple serializer#28400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromfabpot:messenger-simple-serializer
Sep 8, 2018

Conversation

@fabpot
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT
Doc PR#...

When using the Messenger component without Symfony full stack, it helps to use a simple Serializer configured with the bare minimum (this bare minimum is up to the discussion).

@fabpotfabpotforce-pushed themessenger-simple-serializer branch 2 times, most recently from31a0ba0 to4b1b74fCompareSeptember 8, 2018 08:06
@fabpotfabpot requested a review fromsrozeSeptember 8, 2018 08:06
@javiereguiluz
Copy link
Member

I haven't used the Messenger component yet so I'm probably asking something stupid but --> could we make a radical simplification for this "SimpleSerializer" and just usejson_encode() /json_decode() instead of the Symfony Serializer?

@ro0NL
Copy link
Contributor

ro0NL commentedSep 8, 2018
edited
Loading

random thought, but what about putting aSerializerInterface in the contracts namespace, and forget about individual encoder/decoder contracts perhaps (or move those as well).

@fabpot
Copy link
MemberAuthor

It's a bit more involving than that, but having the serializer as a dependency does not add any complexity, so I don't think we need to make it optional. SimpleSerializer is only needed when you are using the component standalone where you would basically have to do what I've done here. So, it only to get you started faster.

@fabpot
Copy link
MemberAuthor

@ro0NL That's my thoughts as well :)

@fabpotfabpotforce-pushed themessenger-simple-serializer branch 3 times, most recently from43696a2 to1c5890aCompareSeptember 8, 2018 11:57
Copy link
Contributor

@srozesroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 (rebase needed)

@fabpotfabpotforce-pushed themessenger-simple-serializer branch from1c5890a tof27c15aCompareSeptember 8, 2018 12:15
@fabpotfabpot merged commitf27c15a intosymfony:masterSep 8, 2018
fabpot added a commit that referenced this pull requestSep 8, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Messenger] Add a simple serializer| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | #...When using the Messenger component without Symfony full stack, it helps to use a simple Serializer configured with the bare minimum (this bare minimum is up to the discussion).Commits-------f27c15a [Messenger] added a simple serializer
This was referencedNov 3, 2018
@fabpotfabpot deleted the messenger-simple-serializer branchJanuary 14, 2019 11:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

2 more reviewers

@ro0NLro0NLro0NL left review comments

@srozesrozesroze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fabpot@javiereguiluz@ro0NL@sroze@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp