Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add a simple serializer#28400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
31a0ba0 to4b1b74fComparejaviereguiluz commentedSep 8, 2018
I haven't used the Messenger component yet so I'm probably asking something stupid but --> could we make a radical simplification for this "SimpleSerializer" and just use |
ro0NL commentedSep 8, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
random thought, but what about putting a |
fabpot commentedSep 8, 2018
It's a bit more involving than that, but having the serializer as a dependency does not add any complexity, so I don't think we need to make it optional. SimpleSerializer is only needed when you are using the component standalone where you would basically have to do what I've done here. So, it only to get you started faster. |
fabpot commentedSep 8, 2018
@ro0NL That's my thoughts as well :) |
src/Symfony/Component/Messenger/Transport/Serialization/SimpleSerializer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
43696a2 to1c5890aCompare
sroze left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 (rebase needed)
1c5890a tof27c15aCompareThis PR was merged into the 4.2-dev branch.Discussion----------[Messenger] Add a simple serializer| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | #...When using the Messenger component without Symfony full stack, it helps to use a simple Serializer configured with the bare minimum (this bare minimum is up to the discussion).Commits-------f27c15a [Messenger] added a simple serializer
When using the Messenger component without Symfony full stack, it helps to use a simple Serializer configured with the bare minimum (this bare minimum is up to the discussion).