Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Blacklist Eurozone and United Nations in Region Data Generator#28396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
gregurco commentedSep 7, 2018
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28260 |
| License | MIT |
| Doc PR | - |
| constBOUVET_ISLAND_ID ='BV'; | ||
| constHEARD_MCDONALD_ISLANDS_ID ='HM'; | ||
| constCLIPPERTON_ISLAND_ID ='CP'; | ||
| constEUROZONE_UNION_ID ='EZ'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
actually, this should be named EUROZONE_ID I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed. I found in wiki that EZ is amonetary union, that's why I added union in constant name 🙂 but yep, finally it's not a usual "union".
nicolas-grekas commentedSep 9, 2018
Actually, the data also had to be updated. I just did it by pushing to your fork. |
nicolas-grekas commentedSep 10, 2018
Thank you@gregurco. |
…a Generator (gregurco)This PR was merged into the 2.8 branch.Discussion----------[Intl] Blacklist Eurozone and United Nations in Region Data Generator| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28260| License | MIT| Doc PR | -Commits-------e2e4049 [Intl] Blacklist Eurozone and United Nations in Region Data Generator