Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] fixed corrupt error output for unknown multibyte short option#28393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:2.8fromdownace:ticket_28320
Sep 10, 2018
Merged

[Console] fixed corrupt error output for unknown multibyte short option#28393

chalasr merged 1 commit intosymfony:2.8fromdownace:ticket_28320
Sep 10, 2018

Conversation

@downace
Copy link
Contributor

QA
Branch?2.8
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28320
LicenseMIT
Doc PR-

[Console]Fixed#28320 by using mb_substr instead of index access

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for contributing

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@downace a nice first contribution to Symfony. Thanks!

@chalasr
Copy link
Member

Thank you@downace.

@chalasrchalasr merged commit0f86156 intosymfony:2.8Sep 10, 2018
chalasr pushed a commit that referenced this pull requestSep 10, 2018
… short option (downace)This PR was squashed before being merged into the 2.8 branch (closes#28393).Discussion----------[Console] fixed corrupt error output for unknown multibyte short option| Q             | A| ------------- | ---| Branch?       | 2.8 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#28320   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | - <!-- required for new features -->[Console]Fixed#28320 by using mb_substr instead of index access<!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------0f86156 [Console] fixed corrupt error output for unknown multibyte short option
This was referencedSep 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@downace@chalasr@javiereguiluz@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp