Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
fix fopen flags#28377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix fopen flags#28377
Uh oh!
There was an error while loading.Please reload this page.
Conversation
SpacePossum commentedSep 6, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | none |
| License | MIT |
| Doc PR | none |
| $this->exitcode =null; | ||
| $this->fallbackStatus =array(); | ||
| $this->processInformation =null; | ||
| $this->stdout =fopen('php://temp/maxmemory:'.(1024 *1024),'wb+'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wb+ is not valid
| */ | ||
| publicfunctionformat(MessageCatalogue$messages,$domain ='messages') | ||
| { | ||
| $handle =fopen('php://memory','rb+'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
rb+ is not valid
nicolas-grekas commentedSep 6, 2018
Hello, can you rebase+retarget on 2.8 please, and also keep only the fixed modes? |
c81b923 toae59908CompareSpacePossum commentedSep 6, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
sure thing@nicolas-grekas 👍 |
fabpot commentedSep 7, 2018
Thank you@SpacePossum. |
This PR was merged into the 2.8 branch.Discussion----------fix fopen flags| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | none<!--Fixes the flags/mode used with `fopen`-->Commits-------6d155ed fix fopen calls