Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Dotenv] use array instead of variadic in Dotenv::doLoad()#28359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromfmata:issue-26846-followup
Sep 5, 2018
Merged

[Dotenv] use array instead of variadic in Dotenv::doLoad()#28359

fabpot merged 1 commit intosymfony:masterfromfmata:issue-26846-followup
Sep 5, 2018

Conversation

@fmata
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsn/a
LicenseMIT

According to comments done after merge in#26859.

@stof
Copy link
Member

stof commentedSep 4, 2018

I'm wondering whether we should move theunshift into both public methods. That would avoid creating a copy of the array, but the copy might not be a big issue (it is unlikely to pass a huge array there)

@xabbuh
Copy link
Member

Movingarray_unshift() into the calling methods would at least improve the readability ofdoLoad() IMO. But that's not a blocker to me.

@fabpot
Copy link
Member

Thank you@fmata.

@fabpotfabpot merged commitf3af242 intosymfony:masterSep 5, 2018
fabpot added a commit that referenced this pull requestSep 5, 2018
…() (fmata)This PR was merged into the 4.2-dev branch.Discussion----------[Dotenv] use array instead of variadic in Dotenv::doLoad()| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MITAccording to comments done after merge in#26859.Commits-------f3af242 [Dotenv] use array instead of variadic in Dotenv::doLoad()
@fmatafmata deleted the issue-26846-followup branchSeptember 5, 2018 09:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fmata@stof@xabbuh@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp