Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients#28344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedSep 3, 2018
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28125 |
| License | MIT |
| Doc PR | - |
fabpot approved these changesSep 3, 2018
fabpot requested changesSep 3, 2018
Uh oh!
There was an error while loading.Please reload this page.
432bf05 toa468188CompareMember
fabpot commentedSep 4, 2018
Looks like tests are broken with this change. |
…sed to test clients
a468188 to2554554CompareMemberAuthor
nicolas-grekas commentedSep 4, 2018
Fixed, should be green soon. |
fabpot approved these changesSep 4, 2018
Member
fabpot commentedSep 4, 2018
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestSep 4, 2018
…ayloads passed to test clients (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28125| License | MIT| Doc PR | -Commits-------2554554 [HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients
This was referencedSep 30, 2018
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.