Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Trigger exception when using '@id' name in parent option#28315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedAug 30, 2018
LGTM on master on my side. |
ro0NL approved these changesAug 31, 2018
fabpot approved these changesSep 4, 2018
Member
fabpot commentedSep 4, 2018
Thank you@Seb33300. |
fabpot added a commit that referenced this pull requestSep 4, 2018
… option (Seb33300)This PR was squashed before being merged into the 4.2-dev branch (closes#28315).Discussion----------[DI] Trigger exception when using '@id' name in parent optionSame exception [already triggered](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php#L505) on the `decorates` option.| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Note sure if I should submit this change for master or previous branches...Commits-------1f67db6 [DI] Trigger exception when using '@id' name in parent option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
DependencyInjectionDXDX = Developer eXperience (anything that improves the experience of using Symfony) Status: Reviewed
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Same exceptionalready triggered on the
decoratesoption.Note sure if I should submit this change for master or previous branches...