Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Remove the "obscure" message subscriber configuration#28294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sroze
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?yes
Fixed ticketsø
LicenseMIT
Doc PRø

As described in#28275, all of the configuration can be done using yield and that we could remove the support for other ways (especially the obscure return[['method', -10]] syntax) as I believe this would clarify the configuration a lot.

Koc reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@sroze.

@fabpotfabpot merged commitcf2ad86 intosymfony:masterAug 29, 2018
fabpot added a commit that referenced this pull requestAug 29, 2018
…nfiguration (sroze)This PR was merged into the 4.2-dev branch.Discussion----------[Messenger] Remove the "obscure" message subscriber configuration| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ø| License       | MIT| Doc PR        | øAs described in#28275, all of the configuration can be done using yield and that we could remove the support for other ways (especially the obscure return `[['method', -10]]` syntax) as I believe this would clarify the configuration a lot.Commits-------cf2ad86 Remove the "obscure" message subscriber configuration
@srozesroze deleted the remove-obscure-subscriber-configuration-method branchAugust 29, 2018 15:28
@javiereguiluz
Copy link
Member

I've createdsymfony/symfony-docs#10278 to document this new feature. Please, don't forget to create a doc issue for every new feature.

The Messenger component docs are not great yet, so I don't know if this was documented and we need to change it or it was never documented and need to add it. Thanks!

This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sroze@fabpot@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp