Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Update changelog about the new $encoderIgnoredNodeTypes arg in XmlEncoder contrustor#28281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
maidmaid commentedAug 27, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27926 |
| License | MIT |
| Doc PR | / |
| *`AbstractNormalizer::handleCircularReference` is now final, and receives two optional extra arguments: the format and the context | ||
| * added support for XML comment encoding (encoding`['#comment' => ' foo ']` results`<!-- foo -->`) | ||
| * added optional`int[] $encoderIgnoredNodeTypes` argument to`XmlEncoder::__construct`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
... to configure node types to be ignored during encodage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, better. Done !
19aee3d tof13b2c9Compare| *`AbstractNormalizer::handleCircularReference` is now final, and receives two optional extra arguments: the format and the context | ||
| * added support for XML comment encoding (encoding`['#comment' => ' foo ']` results`<!-- foo -->`) | ||
| * added optional`int[] $encoderIgnoredNodeTypes` argument to`XmlEncoder::__construct` to configure node types to be | ||
| ignored during encodage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
encoding :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done (\cc@dunglas 😄)
f13b2c9 to584785aCompare584785a to49f3bfcComparefabpot commentedAug 27, 2018
Thank you@maidmaid. |
…redNodeTypes arg in XmlEncoder contrustor (maidmaid)This PR was merged into the 4.2-dev branch.Discussion----------[Serializer] Update changelog about the new $encoderIgnoredNodeTypes arg in XmlEncoder contrustor| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27926| License | MIT| Doc PR | /Commits-------49f3bfc Update changelog