Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] AbstractObjectNormalizer improve performance#28277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
969ff54 to3dcc828Compare| } | ||
| returnnull; | ||
| return$this->typesCache[$key] =null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isset($this->typesCache[$key]) will befalse anyway if the value isnull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right. Now marked asfalse and added extra check at the start to avoid usingarray_key_exists()
aca08e4 to626d93dCompare626d93d to4224145Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
fabpot commentedAug 27, 2018
Thank you@martiis. |
…nce (martiis)This PR was merged into the 4.2-dev branch.Discussion----------[Serializer] AbstractObjectNormalizer improve performance| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28276| License | MITCheck ticket for descriptionCommits-------4224145 [Serializer] AbstractObjectNormalizer improve perf when checking types
Check ticket for description