Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] leverage Contracts\Service#28207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c427a5d to422ce7fCompare| { | ||
| $this->factories =$factories; | ||
| use ServiceLocatorTrait { | ||
| getas doGet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
does this makedoGet public or no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nope, visibility changes must be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok, got it, fixed :)
e8a0a32 to405b4e4Compare8294fc5 to810890eComparefabpot commentedSep 4, 2018
Should be rebased now |
810890e to40cfe7aCompare
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
minor comment
| * | ||
| * @author Christophe Coevoet <stof@notk.org> | ||
| * | ||
| * @deprecated since Symfony 4.2, use `ResetInterface` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be the FQDN here IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
updated (and added to the CHANGELOG file)
40cfe7a to87392abComparefabpot commentedSep 5, 2018
Thank you@nicolas-grekas. |
This PR was merged into the 4.2-dev branch.Discussion----------[DI] leverage Contracts\Service| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Embedding#28206 for now.This deprecates some generic interfaces from the DI component in favor of the similar ones proposed for `Contracts\Service`.Commits-------87392ab [DI] leverage Contracts\Service
Embedding#28206 for now.
This deprecates some generic interfaces from the DI component in favor of the similar ones proposed for
Contracts\Service.