Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] fix false-positive ConflictingHeadersException#28144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // Remove port (unfortunately, it does happen) | ||
| if (preg_match('{((?:\d+\.){3}\d+)\:\d+}',$clientIp,$match)) { | ||
| $clientIps[$key] =$clientIp =$match[1]; | ||
| if (strpos($clientIp,'.')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this part of the patch is a bugfix backported from 4.1, needed by the fix line 1946 (brackets should not be removed from the value)
| ); | ||
| Request::setTrustedProxies(array('88.88.88.88')); | ||
| Request::setTrustedProxies(array('88.88.88.88'), -1); |
nicolas-grekasAug 6, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wrongly set toRequest::HEADER_X_FORWARDED_ALL on 3.4+, this will act as a reminder by the conflict it will create when merging
mateuszbieniek commentedAug 7, 2018
I can confirm that this PR fixedhttps://jira.ez.no/browse/EZP-29497 on my local installation. |
…ption (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[HttpFoundation] fix false-positive ConflictingHeadersException| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28153| License | MIT| Doc PR | -Fixeshttps://jira.ez.no/browse/EZP-29492 &https://jira.ez.no/browse/EZP-29497Ping@andreromCommits-------6089290 [HttpFoundation] fix false-positive ConflictingHeadersException
stloyd commentedAug 16, 2018
@fabpot@nicolas-grekas Can we get |
* 3.4: [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
Uh oh!
There was an error while loading.Please reload this page.
Fixeshttps://jira.ez.no/browse/EZP-29492 &https://jira.ez.no/browse/EZP-29497
Ping@andrerom