Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] leverage Contracts\Cache#28097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aea99b7 to129981aCompare129981a tob2c407bCompareb2c407b to8dbcf87Compare8dbcf87 to6d5b78bCompare
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs to be updated
| <serviceid="Symfony\Component\Cache\Adapter\AdapterInterface"alias="cache.app" /> | ||
| <serviceid="Symfony\Component\Cache\CacheInterface"alias="cache.app.taggable" /> | ||
| <serviceid="Symfony\Contracts\Cache\CacheInterface"alias="cache.app" /> | ||
| <serviceid="Symfony\Contracts\Cache\ExtendedCacheInterface"alias="cache.app" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please remove this line.
| <serviceid="Symfony\Contracts\Cache\CacheInterface"alias="cache.app" /> | ||
| <serviceid="Symfony\Contracts\Cache\ExtendedCacheInterface"alias="cache.app" /> | ||
| <serviceid="Symfony\Contracts\Cache\TagAwareCacheInterface"alias="cache.app.taggable" /> | ||
| <serviceid="Symfony\Contracts\Cache\ExtendedTagAwareCacheInterface"alias="cache.app.taggable" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It should beTagAwareCacheInterface
6d5b78b to4dd84efComparenicolas-grekas commentedAug 30, 2018
thanks fixed |
3e1041f to8737949CompareNyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you. 👍
| * | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| interface CacheInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For the record: This interface has never been released, so it is okey to remove it.
2d2d0f7 tod9f19bcCompare
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
With one small comment
Uh oh!
There was an error while loading.Please reload this page.
4ad3e50 toec22696Compareec22696 todd9fd32Compare| "psr/simple-cache-implementation":"1.0", | ||
| "symfony/cache-contracts":"1.0", | ||
| "symfony/service-contracts":"1.0", | ||
| "symfony/translation-contracts":"1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I realized we should add this. OK to you?
dd9fd32 toefdbbecCompareefdbbec to0a1220fComparenicolas-grekas commentedSep 4, 2018
rebased |
This PR was merged into the 4.2-dev branch.Discussion----------[Cache] leverage Contracts\Cache| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Implementing#28096Commits-------0a1220f [Cache] leverage Contracts\Cache
Implementing#28096