Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Config] show proposals when unsupported option is provided#28085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromfmata:issue-28075
Aug 10, 2018
Merged

[Config] show proposals when unsupported option is provided#28085

nicolas-grekas merged 1 commit intosymfony:masterfromfmata:issue-28075
Aug 10, 2018

Conversation

@fmata
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#28075
LicenseMIT
Doc PRnone

In case of proposals match with the provided option, all proposals are displayed.
In case of no pertinent proposal is available, all options are displayed in alpha order.

sstok reacted with hooray emoji
@chalasrchalasr added the DXDX = Developer eXperience (anything that improves the experience of using Symfony) labelJul 29, 2018
@chalasrchalasr added this to thenext milestoneJul 29, 2018
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with minor comment)


if (\count($guesses)) {
asort($guesses);
$msg .=sprintf('. Did you mean "%s" ?',implode('", "',array_keys($guesses)));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the space before? should be removed

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed.

@nicolas-grekas
Copy link
Member

Thank you@fmata.

@nicolas-grekasnicolas-grekas merged commit15f69a3 intosymfony:masterAug 10, 2018
nicolas-grekas added a commit that referenced this pull requestAug 10, 2018
…vided (fmata)This PR was merged into the 4.2-dev branch.Discussion----------[Config] show proposals when unsupported option is provided| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#28075| License       | MIT| Doc PR        | noneIn case of proposals match with the provided option, all proposals are displayed.In case of no pertinent proposal is available, all options are displayed in alpha order.Commits-------15f69a3 [Config] show proposals when unsupported option is provided
@fmatafmata deleted the issue-28075 branchAugust 10, 2018 07:36
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@sstoksstoksstok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ConfigDXDX = Developer eXperience (anything that improves the experience of using Symfony)FeatureStatus: Reviewed

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@fmata@nicolas-grekas@sstok@xabbuh@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp