Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Workflow] fix guard expressions#28018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $this->transition = $transition; | ||
| $this->expression = $expression; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing EOL. Also please remove all docblocks in this class: they don't provide anything on top of the existing type declaration, and our policy is to not add them in this situation.
destillat commentedJul 26, 2018
After applying cs changes proposed by fabbot.io there are some conflicts with master branch. Should i merge them? |
nicolas-grekas commentedJul 26, 2018
please rebase instead of merging yes |
…ition in configuration
…pass them by reference to guard expressions
a7fe7ea to720f943Comparefabpot commentedSep 4, 2018
@lyrixx Can you review this one? Thank you. |
nicolas-grekas commentedOct 31, 2018
friendly ping@lyrixx |
lyrixx commentedOct 31, 2018
Hello. Sorry for the very late reply. I will have a look tomorrow or after tomorrow. Thanks |
lyrixx commentedNov 8, 2018
Thanks a lot@destillat. I finished you work in#29137 and I rebased against 3.4. |
…ansitions (destillat, lyrixx)This PR was merged into the 3.4 branch.Discussion----------[Workflow][FrameworkBundle] fixed guard event names for transitions| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#28018#28007 (comment)| License | MIT| Doc PR |There is a bug when many transitions are defined with the same name.I finished destillat's work and rebase against 3.4 as it's a bug fix.There another point of failure, but it could not be fixed on 3.4. I willbe a need feature. The issue is related to `Workflow::can($subject, $transitionName)`.Since the transitionName could be not unique, we will need to supportpassing an instance of Transition. A new PR is incommingCommits-------83dc473 [FrameworkBundle] fixed guard event names for transitionsfb88bfc [FrameworkBundle] fixed guard event names for transitions
Uh oh!
There was an error while loading.Please reload this page.
Possible fix for#28007 (comment)