Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Show relative path of the template and improving panel view#27978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
yceruto commentedJul 17, 2018
| @@ -0,0 +1,3 @@ | |||
| <svgversion="1.1"xmlns="http://www.w3.org/2000/svg"x="0px"y="0px"width="24"height="24"viewBox="0 0 24 24"enable-background="new 0 0 24 24"xml:space="preserve"> | |||
| <pathfill="#AAAAAA"d="m8.932327,22.491763c0.015209,-6.448229 -0.971579,-11.295129 -5.994828,-11.618392c4.689807,-0.35251 7.112354,2.633007 9.29714,6.906552c-0.030468,-11.426311 -2.352459,-16.227324 -7.433672,-16.482536c7.433365,0.069108 10.027703,5.898928 11.508208,14.292954c1.170879,-2.282766 3.560547,-5.553431 5.347074,-1.361535c-1.59464,-2.040144 -3.607126,-1.61697 -3.978662,8.261983l-8.744646,0.000107z"/> | |||
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added a new Twig icon (logo), maybe it could be a good opportunity to use it as the main icon of this panel?
| Before | After |
|---|---|
 |  |
 |  |
What do you think?
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updating the icon sounds good to me.
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updated.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twigShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/twig.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/twig.html.twig OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
stof requested changesJul 17, 2018
Uh oh!
There was an error while loading.Please reload this page.
506cd48 to14f5953CompareMemberAuthor
yceruto commentedJul 17, 2018
(fabbot.io, AppVeyor and Travis failure aren't related to these changes) Status: Needs Review |
Uh oh!
There was an error while loading.Please reload this page.
fabpot approved these changesJul 18, 2018
Member
fabpot commentedJul 18, 2018
Thank you@yceruto. |
symfony-splitter pushed a commit to symfony/web-profiler-bundle that referenced this pull requestJul 18, 2018
… and improving panel view (yceruto)This PR was merged into the 4.2-dev branch.Discussion----------[WebProfilerBundle] Show relative path of the template and improving panel view| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #27911| License | MIT| Doc PR | -| Before | After || --- | --- ||  |  |symfony/symfony#27978 (comment):| Before | After || --- | --- ||  | |  |  |In addition, I added some visual improvements.Commits-------bcd8058478 Show relative path of the template and improving panel view
symfony-splitter pushed a commit to symfony/twig-bridge that referenced this pull requestJul 18, 2018
… and improving panel view (yceruto)This PR was merged into the 4.2-dev branch.Discussion----------[WebProfilerBundle] Show relative path of the template and improving panel view| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #27911| License | MIT| Doc PR | -| Before | After || --- | --- ||  |  |symfony/symfony#27978 (comment):| Before | After || --- | --- ||  | |  |  |In addition, I added some visual improvements.Commits-------bcd8058478 Show relative path of the template and improving panel view
fabpot added a commit that referenced this pull requestJul 18, 2018
… and improving panel view (yceruto)This PR was merged into the 4.2-dev branch.Discussion----------[WebProfilerBundle] Show relative path of the template and improving panel view| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27911| License | MIT| Doc PR | -| Before | After || --- | --- ||  |  |#27978 (comment):| Before | After || --- | --- ||  | |  |  |In addition, I added some visual improvements.Commits-------bcd8058 Show relative path of the template and improving panel view
MemberAuthor
yceruto commentedJul 18, 2018
I missed here a failed test in AppVeyorhttps://ci.appveyor.com/project/fabpot/symfony/build/1.0.38700#L616 (fixing in#27986) |
fabpot added a commit that referenced this pull requestJul 19, 2018
This PR was merged into the 4.2-dev branch.Discussion----------Fix test file relative for AppVeyor| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Fix test for AppVeyor introduced in#27978https://ci.appveyor.com/project/fabpot/symfony/build/1.0.38700#L616Commits-------186a7a9 Fix test file relative for AppVeyor
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
#27978 (comment):
In addition, I added some visual improvements.