Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Remember me: allow to set the samesite cookie flag#27976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
chalasr approved these changesJul 17, 2018
fabpot approved these changesJul 18, 2018
Member
fabpot commentedJul 18, 2018
Thank you@dunglas. |
fabpot added a commit that referenced this pull requestJul 18, 2018
…ie flag (dunglas)This PR was merged into the 4.2-dev branch.Discussion----------[Security] Remember me: allow to set the samesite cookie flag| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | no| Fixed tickets | no| License | MIT| Doc PR |symfony/symfony-docs#10077This PR allows to set the [`samesite`](https://www.owasp.org/index.php/SameSite) cookie flag for remember me token cookies.Commits-------337e8ef [Security] Remember me: allow to set the samesite cookie flag
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJul 18, 2018
This PR was merged into the master branch.Discussion----------[Security] Remember me: samesite cookiesymfony/symfony#27976Commits-------eefa182 [Security] Remember me: samesite cookie
nicolas-grekas added a commit that referenced this pull requestMar 23, 2020
…kie flag (dunglas)This PR was merged into the 3.4 branch.Discussion----------[Security/Http] Remember me: allow to set the samesite cookie flag| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Similar to#35605, since Chrome 80 is going to require the `samesite` attribute.This is a cherry-pick of#27976Commits-------f0ceb73 [Security] Remember me: allow to set the samesite cookie flag
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR allows to set the
samesitecookie flag for remember me token cookies.