Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] Add fallback to cultureless locale for internationalized routes#27957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

@fancywebfancyweb commentedJul 15, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27938
LicenseMIT
Doc PRsymfony/symfony-docs#10108

Please check the related issue for the context.

TODO :

  • Update CHANGELOG
  • Update documentation

XWB, apfelbox, sstok, and andreybolonin reacted with hooray emoji
$this->generatorDumper =newPhpGeneratorDumper($this->routeCollection);
$this->testTmpFilepath =sys_get_temp_dir().DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.php';
$this->largeTestTmpFilepath =sys_get_temp_dir().DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.large.php';
$this->testTmpFilepath =sys_get_temp_dir().\DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.php';
Copy link
ContributorAuthor

@fancywebfancywebJul 15, 2018•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These changes were applied by the fabbot patch. I guess I should revert them ?

@fancywebfancywebforce-pushed thefeat-i18n-routing-locale-fallback branch from3ae6eaa tobd5dc07CompareJuly 21, 2018 10:44
@fancywebfancyweb changed the title[WIP][Routing] Add locale fallback to internationalized routes[Routing] Add locale fallback to internationalized routesJul 21, 2018
@nicolas-grekasnicolas-grekas added this to thenext milestoneJul 23, 2018
@nicolas-grekasnicolas-grekas changed the title[Routing] Add locale fallback to internationalized routes[Routing] Add fallback to cultureless locale for internationalized routesJul 23, 2018
@nicolas-grekasnicolas-grekasforce-pushed thefeat-i18n-routing-locale-fallback branch frombd5dc07 tobb9ccbfCompareJuly 23, 2018 11:26
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(just updated the implementation to make it shorter)

@fancyweb
Copy link
ContributorAuthor

@nicolas-grekas Great job on making this shorter ! Is there any performance impact to "reprocess" everything everytime you generate an url ?

@nicolas-grekas
Copy link
Member

performance impact to "reprocess

the only impact this can have are at most two extra calls to strstr. I think that's OK :)

@nicolas-grekas
Copy link
Member

(please fix fabbot issues)

@nicolas-grekasnicolas-grekasforce-pushed thefeat-i18n-routing-locale-fallback branch frombb9ccbf tofd2e3c3CompareAugust 10, 2018 07:14
@nicolas-grekas
Copy link
Member

Thank you@fancyweb.

@nicolas-grekasnicolas-grekas merged commitfd2e3c3 intosymfony:masterAug 10, 2018
nicolas-grekas added a commit that referenced this pull requestAug 10, 2018
…nationalized routes (fancyweb)This PR was merged into the 4.2-dev branch.Discussion----------[Routing] Add fallback to cultureless locale for internationalized routes| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27938| License       | MIT| Doc PR        |symfony/symfony-docs#10108Please check the related issue for the context.TODO :- [x] Update CHANGELOG- [x] Update documentationCommits-------fd2e3c3 [Routing] Add fallback to cultureless locale for internationalized routes
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestSep 4, 2018
…s (Thomas Calvet, javiereguiluz)This PR was merged into the master branch.Discussion----------[Routing] Add locale fallback to internationalized routesRelated PR :symfony/symfony#27957Commits-------02cc739 Minor rewordc15df9d [Routing] Add locale fallback to internationalized routes
@ampaze
Copy link
Contributor

Thanks from me as well.

xabbuh reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
@fancywebfancyweb deleted the feat-i18n-routing-locale-fallback branchAugust 9, 2019 07:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@fancyweb@nicolas-grekas@ampaze@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp