Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2#27941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thank you@jmsche. |
…trap 4.1.2 (jmsche)This PR was merged into the 2.8 branch.Discussion----------[WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes?| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/AHi,This PR fixes an issue introduced by Bootstrap 4.1.2: it vertically aligns SVG icons in the middle instead of letting it stay at the baseline.I'm not sure this PR is relevant but, if I'm not the only Bootstrap user, I guess it will be useful to many and it does not break anything: it enforces what should be default.[Update] Here is the related PR merged into Bootstrap that causes the issue:twbs/bootstrap#25874[Update 2] Before the fix:After the fix:Commits-------ecef6f1 [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2
| @@ -263,6 +263,7 @@ div.sf-toolbar .sf-toolbar-block a:hover { | |||
| border-width: 0; | |||
| position: relative; | |||
| top: 8px; | |||
| vertical-align: baseline; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should it actually also apply to images ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess that shouldn't be an issue as the same is already applied to.sf-toolbarreset *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For me, the css rule already exist in.sf-toolbarreset * selector. It's not necessary to duplicate this rule. Just improve it.
Add!important and that's ok. No ?
Uh oh!
There was an error while loading.Please reload this page.
Hi,
This PR fixes an issue introduced by Bootstrap 4.1.2: it vertically aligns SVG icons in the middle instead of letting it stay at the baseline.
I'm not sure this PR is relevant but, if I'm not the only Bootstrap user, I guess it will be useful to many and it does not break anything: it enforces what should be default.
[Update] Here is the related PR merged into Bootstrap that causes the issue:twbs/bootstrap#25874
[Update 2] Before the fix:
After the fix: