NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpFoundation] reset callback on StreamedResponse when setNotModified() is called#27937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.8fromrubencm:ticket/27924

Jul 13, 2018

Merged

[HttpFoundation] reset callback on StreamedResponse when setNotModified() is called#27937

fabpot merged 1 commit intosymfony:2.8fromrubencm:ticket/27924

Jul 13, 2018

Conversation

Copy link

Contributor

rubencm commentedJul 13, 2018

Q	A
Branch?	2.8
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#27924
License	MIT
Doc PR	No

carsonbot added Status: Needs Review HttpFoundation Bug labels

Jul 13, 2018

rubencm force-pushed theticket/27924 branch fromc3eb986 to28f6aa3Compare

July 13, 2018 05:37

[HttpFoundation] reset callback on StreamedResponse when setNotModifi…

51a49c7

…ed() is called

rubencm force-pushed theticket/27924 branch from28f6aa3 to51a49c7Compare

July 13, 2018 06:54

carsonbot removed the Status: Needs Review label

Jul 13, 2018

fabpot approved these changes

Jul 13, 2018

View reviewed changes

carsonbot added the Status: Reviewed label

Jul 13, 2018

Copy link

Member

fabpot commentedJul 13, 2018

Thank you@rubencm.

fabpot merged commit51a49c7 intosymfony:2.8

Jul 13, 2018

fabpot added a commit that referenced this pull request

Jul 13, 2018

bug#27937[HttpFoundation] reset callback on StreamedResponse when s…

f803762

…etNotModified() is called (rubencm)This PR was merged into the 2.8 branch.Discussion----------[HttpFoundation] reset callback on StreamedResponse when setNotModified() is called| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27924| License       | MIT| Doc PR        | NoCommits-------51a49c7 [HttpFoundation] reset callback on StreamedResponse when setNotModified() is called

This was referencedJul 23, 2018

Release v2.8.43#28031

Merged

Release v3.4.13#28039

Merged

Release v4.0.13#28042

Merged

Release v4.1.2#28043

Merged

nicolas-grekas mentioned this pull request

Sep 16, 2018

[HttpFoundation] don't override StreamedResponse::setNotModified()#28483

Merged

fabpot added a commit that referenced this pull request

Sep 18, 2018

minor#28483[HttpFoundation] don't override StreamedResponse::setNot…

a9004b3

…Modified() (nicolas-grekas)This PR was merged into the 2.8 branch.Discussion----------[HttpFoundation] don't override StreamedResponse::setNotModified()| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Alternative implementation to#27937, because `Response::setNotModified()` has been made final in 4.0 so we shouldn't override it.Commits-------9ef7f70 [HttpFoundation] don't override StreamedResponse::setNotModified()