Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] [Command] TranslationUpdate change default output to xlf#27935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@R2c
Copy link

@R2cR2c commentedJul 12, 2018
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsNot applicable
LicenseMIT
Doc PRNot applicable

Simple modification on the default output for the translation: update command to XLIFF (xlf)
It's to be in agreement with the documentation

image

Link to the documentation :
https://symfony.com/doc/master/translation.html#translation-resource-file-names-and-locations

@R2cR2c changed the title[FrameworkBundle] Cmd TranslationUpdate change default output to xlf[FrameworkBundle] [Command] TranslationUpdate change default output to xlfJul 12, 2018
@javiereguiluz
Copy link
Member

@R2c thanks for sending your first contribution to Symfony!

I like this change a lot ... but sadly it's a backward compatibility break. Any existing command that doesn't specify the format gets the output in YML. If we make this change, the output will be XLIFF and things could break.

If we want to make this change, we need to find a way of doing it without breaking existing commands. Thanks!

pamil reacted with thumbs up emoji

@R2c
Copy link
Author

R2c commentedJul 13, 2018
edited
Loading

I searched in Symfony, i don't find another command with output format in YML.
Maybe i'm wrong, but i think this command is clearly manual (dev).
I don't think people use this command in production, with crontab, etc.
That's why I put it on master.

I'm opened to make more changes, any idea about the compatibility ?

  • Adding message on the changelog ?
  • Adding message on the command... Starting at 3.4 - Output format will change in 4.2 to xliff

@ro0NL
Copy link
Contributor

ro0NL commentedJul 13, 2018
edited
Loading

given ppl expect yaml format today, and with this change, should useformat=yml in the future... we could deprecate not passing a format, so we can change the default in 5.0

not sure if worth it :)

pamil reacted with thumbs up emoji

@fabpot
Copy link
Member

As this command is indeed something people run manually, I don't think changing the default is worth it.

@R2c
Copy link
Author

R2c commentedJul 19, 2018

My constat was :

Starting to use SF4 from the skeleton to look / try every changes. So I try a lot of stuff, when i try to install/use the translation part, i was suprise to see a .yml file? it's not .yaml in SF4 🤔

I use SF since a lot of years, but i'm imagining someone who start with it, i'm sure he will not understand why and it's look like a bug.

If we don't change now, it'll never change.

@nicolas-grekasnicolas-grekas added this to thenext milestoneJul 23, 2018
@nicolas-grekas
Copy link
Member

I don't see any simple way to change the default value without any BC break either. Which means that yes, it should stay as is forever.
We could still allow passing "yaml" as output-format?

@fabpot
Copy link
Member

What do we do here? I don't think we have a non-BC break policy on commands (I'm pretty sure we broke some in the past). Documenting the change in the CHANGELOG could be enough?

@fabpot
Copy link
Member

Thank you@R2c.

R2c reacted with thumbs up emoji

@fabpotfabpot merged commit137593e intosymfony:masterSep 4, 2018
fabpot added a commit that referenced this pull requestSep 4, 2018
…efault output to xlf (Alexis BOYER)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] [Command] TranslationUpdate change default output to xlf| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | Not applicable| License | MIT| Doc PR | Not applicableSimple modification on the default output for the translation: update command to XLIFF (xlf)It's to be in agreement with the documentation![image](https://user-images.githubusercontent.com/2004449/42637935-a91dcabc-85ec-11e8-86db-9c8bea5e710b.png)Link to the documentation :https://symfony.com/doc/master/translation.html#translation-resource-file-names-and-locationsCommits-------137593e [FrameworkBundle] Cmd TranslationUpdate change default output to xlf
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@R2c@javiereguiluz@ro0NL@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp