Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] [Command] TranslationUpdate change default output to xlf#27935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[FrameworkBundle] [Command] TranslationUpdate change default output to xlf#27935
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedJul 13, 2018
@R2c thanks for sending your first contribution to Symfony! I like this change a lot ... but sadly it's a backward compatibility break. Any existing command that doesn't specify the format gets the output in YML. If we make this change, the output will be XLIFF and things could break. If we want to make this change, we need to find a way of doing it without breaking existing commands. Thanks! |
R2c commentedJul 13, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I searched in Symfony, i don't find another command with output format in YML. I'm opened to make more changes, any idea about the compatibility ?
|
ro0NL commentedJul 13, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
given ppl expect yaml format today, and with this change, should use not sure if worth it :) |
fabpot commentedJul 18, 2018
As this command is indeed something people run manually, I don't think changing the default is worth it. |
R2c commentedJul 19, 2018
My constat was : Starting to use SF4 from the skeleton to look / try every changes. So I try a lot of stuff, when i try to install/use the translation part, i was suprise to see a .yml file? it's not .yaml in SF4 🤔 I use SF since a lot of years, but i'm imagining someone who start with it, i'm sure he will not understand why and it's look like a bug. If we don't change now, it'll never change. |
nicolas-grekas commentedJul 23, 2018
I don't see any simple way to change the default value without any BC break either. Which means that yes, it should stay as is forever. |
fabpot commentedAug 28, 2018
What do we do here? I don't think we have a non-BC break policy on commands (I'm pretty sure we broke some in the past). Documenting the change in the CHANGELOG could be enough? |
fabpot commentedSep 4, 2018
Thank you@R2c. |
…efault output to xlf (Alexis BOYER)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] [Command] TranslationUpdate change default output to xlf| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | Not applicable| License | MIT| Doc PR | Not applicableSimple modification on the default output for the translation: update command to XLIFF (xlf)It's to be in agreement with the documentationLink to the documentation :https://symfony.com/doc/master/translation.html#translation-resource-file-names-and-locationsCommits-------137593e [FrameworkBundle] Cmd TranslationUpdate change default output to xlf
Uh oh!
There was an error while loading.Please reload this page.
Simple modification on the default output for the translation: update command to XLIFF (xlf)
It's to be in agreement with the documentation
Link to the documentation :
https://symfony.com/doc/master/translation.html#translation-resource-file-names-and-locations