Thisfixes#27874
I'm not sure about the update in composer.json though. It seems a good idea because I was able to run composer update without the zip extension. If required, I'll remove it.

carsonbot added Status: Needs Review Yaml Bug labels

Jul 8, 2018

fabpot previously requested changes

Jul 12, 2018

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

/cc@xabbuh

composer.json OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Jul 12, 2018

stof previously requested changes

Jul 12, 2018

View reviewed changes

src/Symfony/Component/Yaml/Parser.php OutdatedShow resolvedHide resolved

xabbuh reviewed

Jul 12, 2018

View reviewed changes

src/Symfony/Component/Yaml/Parser.php OutdatedShow resolvedHide resolved

guiguiboy force-pushed theticket_27874 branch from7ed6318 to1027180Compare

July 13, 2018 12:45

xabbuh reviewed

Jul 13, 2018

View reviewed changes

src/Symfony/Component/Yaml/Tests/ParserTest.php OutdatedShow resolvedHide resolved

guiguiboy force-pushed theticket_27874 branch from3c6a833 to8d85944Compare

July 19, 2018 12:41

nicolas-grekas added this to the4.1 milestone

Jul 23, 2018

Copy link

Member

fabpot commentedSep 4, 2018

@xabbuh Can you review this one one more time please?

Copy link

Member

stof commentedSep 4, 2018

As this introduce a new deprecation, it should go in master, not in 4.1. We don't introduce deprecations in patch releases.

Copy link

ContributorAuthor

guiguiboy commentedOct 2, 2018

Hello, I missed your message. I'll rebase shortly.

guiguiboy changed the base branch from4.1 tomaster

October 2, 2018 19:45

guiguiboy force-pushed theticket_27874 branch from8d85944 tod95792dCompare

October 2, 2018 20:01

Copy link

Member

@guiguiboy I will look into the changes in more depth shortly. Thanks so far. 👍 Can you in the meantime please document the deprecation in the upgrade files and in the changelog file of the Yaml component?

guiguiboy force-pushed theticket_27874 branch fromd95792d to069fa71Compare

October 13, 2018 20:26

Copy link

ContributorAuthor

guiguiboy commentedOct 13, 2018

I updated the files supposing it will go in version 5.0.0. If required, I can change back to 4.2.0.

chalasr modified the milestones:4.1,next

Nov 1, 2018

xabbuh requested changes

Dec 17, 2018

View reviewed changes

src/Symfony/Component/Yaml/Parser.php OutdatedShow resolvedHide resolved

UPGRADE-5.0.md OutdatedShow resolvedHide resolved

src/Symfony/Component/Yaml/CHANGELOG.md OutdatedShow resolvedHide resolved

guiguiboy force-pushed theticket_27874 branch 2 times, most recently from069fa71 to532cce8Compare

December 28, 2018 15:17

xabbuh approved these changes

Dec 30, 2018

View reviewed changes

Copy link

Member

xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with a minor tweak to the deprecation message

src/Symfony/Component/Yaml/Parser.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Dec 30, 2018

guiguiboy force-pushed theticket_27874 branch from458bf0b tob11e522Compare

January 5, 2019 13:05

guiguiboy force-pushed theticket_27874 branch fromf87315f tob190d9fCompare

January 25, 2019 20:38

Added deprecation notice when mapping keys are found in multi-line bl…

7bf8381

…ocks

guiguiboy force-pushed theticket_27874 branch fromb190d9f to7bf8381Compare

January 25, 2019 20:49

xabbuh dismissed stale reviews fromstof andfabpot

February 6, 2019 08:39

changes have been addressed

Copy link

Member

xabbuh commentedFeb 6, 2019

Thank you@guiguiboy.

xabbuh merged commit7bf8381 intosymfony:master

Feb 6, 2019

xabbuh added a commit that referenced this pull request

Feb 6, 2019

feature#27898[Yaml] Fixed invalid Parser behavior (guiguiboy)

974cab3

This PR was merged into the 4.3-dev branch.Discussion----------[Yaml] Fixed invalid Parser behavior| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27874| License       | MIT| Doc PR        | NAThisfixes#27874I'm not sure about the update in composer.json though. It seems a good idea because I was able to run composer update without the zip extension. If required, I'll remove it.Commits-------7bf8381 Added deprecation notice when mapping keys are found in multi-line blocks

nicolas-grekas modified the milestones:next,4.3

Apr 30, 2019