Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] deprecate non string requirement names#27879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@xabbuh
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Basically, this will help catching wrong@Route annotation configurations like the following which can lead to hard to debug issues:

@Route("/{foo}", requirements={"foo","bar"})

@xabbuh
Copy link
MemberAuthor

An alternative solution could be to catch such cases in the annotation loader and provide a meaningful error/warning message.

@xabbuhxabbuhforce-pushed therouting-non-string-requirement-names branch 2 times, most recently from7f836be to746f38bCompareJuly 9, 2018 13:18
@xabbuhxabbuhforce-pushed therouting-non-string-requirement-names branch from746f38b to8bb5266CompareJuly 9, 2018 13:38
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit8bb5266 intosymfony:masterJul 11, 2018
fabpot added a commit that referenced this pull requestJul 11, 2018
This PR was merged into the 4.2-dev branch.Discussion----------[Routing] deprecate non string requirement names| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Basically, this will help catching wrong `@Route` annotation configurations like the following which can lead to hard to debug issues:```php@route("/{foo}", requirements={"foo", "bar"})```Commits-------8bb5266 deprecate non string requirement names
@xabbuhxabbuh deleted the routing-non-string-requirement-names branchJuly 11, 2018 15:55
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh@fabpot@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp