Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes()#27870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vudaltsov commentedJul 6, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| * | ||
| * $routes->import('config/routing.yml'); | ||
| * $routes->add('/admin', 'AppBundle:Admin:dashboard', 'admin_dashboard'); | ||
| * $routes->add('/admin', 'App\Controller\AdminController::dashboardAction', 'admin_dashboard'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest to drop theAction suffix (as recommended byhttps://symfony.com/doc/current/best_practices/controllers.html#controller-action-naming)
vudaltsov commentedJul 6, 2018
@chalasr , done! |
| * | ||
| * $routes->import('config/routing.yml'); | ||
| * $routes->add('/admin', 'AppBundle:Admin:dashboard', 'admin_dashboard'); | ||
| * $routes->add('/admin', 'App\Controller\AdminController::dashboard', 'admin_dashboard'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't this be a single colon now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
didn't we deprecate single colon syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here's were it happened#26085
So if I got it right, we now haveClass::method instead ofa:b:c anda:b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
deprecation for OAuth bundle says the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
indeed, I confused that
d9f62dd to948c841Comparenicolas-grekas commentedJul 7, 2018
Thank you@vudaltsov. |
…igureRoutes() (vudaltsov)This PR was merged into the 4.1 branch.Discussion----------[FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes()| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------948c841 [FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes()