Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Don't show internal service id on binding errors#27834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromnicolas-grekas:di-bind-error
Jul 4, 2018

Conversation

nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Will throw
Unused binding "$variableName" in service "App\Twig\AppExtension".
instead of the current
Unused binding "$variableName" in service ".abstract.instanceof.App\Twig\AppExtension".

@stof
Copy link
Member

stof commentedJul 4, 2018

this needs tests

@nicolas-grekas
Copy link
MemberAuthor

now tested

@nicolas-grekasnicolas-grekas merged commit61f005a intosymfony:3.4Jul 4, 2018
nicolas-grekas added a commit that referenced this pull requestJul 4, 2018
…olas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Don't show internal service id on binding errors| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Will throw    Unused binding "$variableName" in service "App\Twig\AppExtension".instead of the current    Unused binding "$variableName" in service ".abstract.instanceof.App\Twig\AppExtension".Commits-------61f005a [DI] Don't show internal service id on binding errors
@nicolas-grekasnicolas-grekas deleted the di-bind-error branchJuly 4, 2018 15:43
This was referencedJul 23, 2018
@viccherubini
Copy link

This appears to have broken my code in 3.4.13. I upgraded and I now get this error even if the binding is used in the code itself. I manually changed the file in question,ResolveInstanceofConditionalsPass.php to what it was in 3.4.12 and the CLI works fine (the application itself appears to work fine).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@stofstofstof approved these changes

@chalasrchalasrchalasr approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

6 participants
@nicolas-grekas@stof@viccherubini@javiereguiluz@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp