Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Check for Hyper terminal on all operating systems.#27831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@fabpot 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 once fabbot happy
| @@ -225,14 +225,17 @@ private static function hasColorSupport() | |||
| if (!defined('STDOUT')) { | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
extra spaces here, blank line should be unchanged. See fabbot patch in the CI
| if ('Hyper' === getenv('TERM_PROGRAM')) { | ||
| return true; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same
@chalasr 👍 |
Thank you@azjezz. |
This PR was squashed before being merged into the 2.8 branch (closes#27831).Discussion---------- Check for Hyper terminal on all operating systems.| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITreturn true if the terminal is Hyper.is on all operating systems not limited to windows.Commits-------196e708 Check for Hyper terminal on all operating systems.
… (theofidry)This PR was merged into the 5.4 branch.Discussion----------[Console] Fix color support check on non-Windows platforms| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues |Fix#45917| License | MITCurrently checking the color support based on `ANSICON`, `ConEmuANSI=ON` or `TERM=xTerm` is done only for Widows. I could not find any reason as to why and it does not make much sense as it is. Especially if we consider that `TERM=xTerm` is a term check and we do another one (not Widows specific) which is `TERM_PROGRAM=Hyper`.This potentiallyfixes#45917.This also looks more in line with the intent (based on the title) of#27831 and#27794.Commits-------285518d detect colors on not windows
return true if the terminal is Hyper.is on all operating systems not limited to windows.