Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] fix typo in phpdoc#27777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * Writes a message to the output and adds a newline at the end. | ||
| * | ||
| * @param string|iterable $messages The message as an iterable of linesof a single string | ||
| * @param string|iterable $messages The message as an iterable of linesor a single string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/lines/string/ also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In this case the strings are output as lines (writeLn). But I don't mind to change it as well if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that'd be consistent IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with this suggestion too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Re-reading, I'd prefer to keep "lines" above, don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think I prefer talking about php types only, but no strong opinion really.
nicolas-grekas commentedJul 9, 2018
Thank you@Tobion. |
This PR was merged into the 2.8 branch.Discussion----------[Console] fix typo in phpdoc| Q | A| ------------- | ---| Branch? | 4.1 (#26847)| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Commits-------7aa4557 [Console] fix typo in phpdoc
Uh oh!
There was an error while loading.Please reload this page.