Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarDumper] show proxified class on hover#27766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:dump-proxy
Jun 30, 2018

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

capture d ecran de 2018-06-29 08-18-59

linaori, apetitpa, and ogizanagi reacted with thumbs up emoji
@javiereguiluz
Copy link
Member

I like this a lot! Just a minor comment: I wonder if instead ofApp\Foo@proxy we should display it asApp\Foo proxy orProxy of App\Foo class ?

@nicolas-grekas
Copy link
MemberAuthor

There is one technical constraint: the last\ controls what's dumped (everything after it -Foo@proxy in the example) vs what's displayed on hover (the full string -Foo_9991422 - App\Foo@proxy). I'm not sure this proposal would fit.

javiereguiluz reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit955494c intosymfony:masterJun 30, 2018
fabpot added a commit that referenced this pull requestJun 30, 2018
…kas)This PR was merged into the 4.2-dev branch.Discussion----------[VarDumper] show proxified class on hover| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -![capture d ecran de 2018-06-29 08-18-59](https://user-images.githubusercontent.com/243674/42076362-2ab0dd1c-7b75-11e8-9243-5e2f78afe870.png)Commits-------955494c [VarDumper] show proxified class on hover
@nicolas-grekasnicolas-grekas deleted the dump-proxy branchJuly 1, 2018 07:50
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@javiereguiluz@fabpot@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp