Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Append new ajax request to the end of the list#27763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
BoShurik commentedJun 28, 2018
Not sure that failed build is related to the changes... |
javiereguiluz commentedJul 3, 2018
Let's ask some heavy users of Ajax requests (like@ostrolucky) what do they think of this proposal. I "remember" that in the past we did the opposite change ... but I'm not sure at all. Thanks! |
ostrolucky commentedJul 3, 2018
I don't remember this being at bottom ever |
BoShurik commentedJul 3, 2018
@ostrolucky this behaviour was at the first (light) profiler design with symfony <=2.7 |
BoShurik commentedJul 3, 2018
Before:
After:
|
stof commentedJul 3, 2018
stof commentedJul 3, 2018
btw, your GIF shows that you are reintroducing the behavior which was asked for removal: having to scroll to be able to see the latest requests. |
BoShurik commentedJul 3, 2018
@stof missed that one. Is this the only reason? What about this behavior:
|
ostrolucky commentedJul 3, 2018
I think that would be best. It mimics behaviour of browser network inspectors |
fabpot commentedAug 2, 2018
Thank you@BoShurik. |
… of the list (BoShurik)This PR was squashed before being merged into the 4.2-dev branch (closes#27763).Discussion----------[WebProfilerBundle] Append new ajax request to the end of the listAppend new ajax request to the end of the list instead of adding it to the beginning| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes/no| BC breaks? | no/yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Didn't find why this behavior was changed with web profiler design.In current version it is hard to click to the latest ajax request.Commits-------45d4559 [WebProfilerBundle] Append new ajax request to the end of the list
| row.className='sf-ajax-request sf-ajax-request-loading'; | ||
| tbody.insertBefore(row,tbody.firstChild); | ||
| tbody.insertBefore(row,null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isn't thattbody.appendChild(row) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@stof oh, missed that one. Is it worth a new PR?
Append new ajax request to the end of the list instead of adding it to the beginning
Didn't find why this behavior was changed with web profiler design.
In current version it is hard to click to the latest ajax request.