Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] fix session tracking counter#27714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

dmaicher
Copy link
Contributor

@dmaicherdmaicher commentedJun 25, 2018•
edited by nicolas-grekas
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?no
Fixed tickets-
LicenseMIT
Doc PR-

As just discussed with@nicolas-grekas I found this issue today while upgrading my app to 3.4.12. Somehow its not possible anymore to set caching headers correctly since this commit:146e01c#diff-5350dc763df30ada9d00563c115f6652

jewome62, soyuka, and teohhanhui reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneJun 25, 2018
@nicolas-grekasnicolas-grekasforce-pushed thecache-control-headers-issue branch from4542d92 to7569f23CompareJune 27, 2018 11:19
@nicolas-grekasnicolas-grekas changed the title[HttpFoundation][HttpKernel] added test case to show problem with cache control headers[HttpFoundation] fix session tracking counterJun 27, 2018
@nicolas-grekasnicolas-grekasforce-pushed thecache-control-headers-issue branch from7569f23 to4419573CompareJune 27, 2018 11:27
@nicolas-grekasnicolas-grekasforce-pushed thecache-control-headers-issue branch from4419573 to2b0beacCompareJune 27, 2018 11:38
@nicolas-grekasnicolas-grekasforce-pushed thecache-control-headers-issue branch from2b0beac to89ed756CompareJune 27, 2018 11:47
@nicolas-grekas
Copy link
Member

Thanks@dmaicher, I pushed the fix here also.

PR ready. The session tracker was too eager.

teohhanhui and jewome62 reacted with thumbs up emoji

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can confirm it fixes the API Platform test suite.

@teohhanhui
Copy link
Contributor

Unfortunately the tests added in this PR are still failing...

@nicolas-grekas
Copy link
Member

Don't be sad, that happens all the time.
Yet in this specific case, the failure is a false-positive that will be fixed by a merge up to master.

teohhanhui and dmaicher reacted with thumbs up emojiteohhanhui reacted with laugh emojiteohhanhui reacted with heart emoji

@nicolas-grekas
Copy link
Member

Thank you@dmaicher.

@nicolas-grekasnicolas-grekas merged commit89ed756 intosymfony:3.4Jun 28, 2018
nicolas-grekas added a commit that referenced this pull requestJun 28, 2018
…kas, dmaicher)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] fix session tracking counter| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | no| Fixed tickets | -| License       | MIT| Doc PR        | -As just discussed with@nicolas-grekas I found this issue today while upgrading my app to 3.4.12. Somehow its not possible anymore to set caching headers correctly since this commit:146e01c#diff-5350dc763df30ada9d00563c115f6652Commits-------89ed756 failing test to reproduce session problem26fc4e6 [HttpFoundation] fix session tracking counter
@fabpotfabpot mentioned this pull requestJul 23, 2018
This was referencedJul 23, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dunglasdunglasdunglas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

7 participants
@dmaicher@nicolas-grekas@teohhanhui@dunglas@remmel@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp