Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Dont throw if "security.http_utils" is not found#27701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromnicolas-grekas:sec-fix
Jun 25, 2018

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27445
LicenseMIT
Doc PR-

The comment + test were misleading, the actual important thing is wiringAddSessionDomainConstraintPass before removing passes, which is already the case already.

@nicolas-grekasnicolas-grekas merged commitdb88330 intosymfony:3.4Jun 25, 2018
nicolas-grekas added a commit that referenced this pull requestJun 25, 2018
…t found (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] Dont throw if "security.http_utils" is not found| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27445| License       | MIT| Doc PR        | -The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already.Commits-------db88330 [SecurityBundle] Dont throw if "security.http_utils" is not found
@fabpotfabpot mentioned this pull requestJun 25, 2018
@nicolas-grekasnicolas-grekas deleted the sec-fix branchJune 25, 2018 12:45
This was referencedJun 25, 2018
@alexislefebvre
Copy link
Contributor

alexislefebvre commentedJun 29, 2018•
edited
Loading

It looks like it revertsc003b7a, but this PR targets Symfony 3.4, whilec003b7a targeted 2.7. Should it be backported to Symfony 2.7 and/or 2.8?

I had the same bug when launching tests that worked 5 months ago :https://travis-ci.org/alexislefebvre/AsyncTweetsBundle/builds/398227684 is broken but the same commit tested 5 months ago didn't crash:https://travis-ci.org/alexislefebvre/AsyncTweetsBundle/builds/339996354

nicolas-grekas added a commit that referenced this pull requestJun 29, 2018
…t found (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] Dont throw if "security.http_utils" is not found| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27445| License       | MIT| Doc PR        | -The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already.Commits-------db88330 [SecurityBundle] Dont throw if "security.http_utils" is not found
@nicolas-grekas
Copy link
MemberAuthor

@alexislefebvre you're right! 2.7 is out of maintenance, so here is the cherry-pick on 2.8:6e5c15d

alexislefebvre reacted with hooray emoji

@alexislefebvre
Copy link
Contributor

You were fast, thanks@nicolas-grekas :)

nicolas-grekas added a commit that referenced this pull requestJun 29, 2018
* 2.8:  [HttpFoundation] update phpdoc of FlashBagInterface::add()  bug#27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)  [Validator] Fix the namespace of RegexTest
nicolas-grekas added a commit that referenced this pull requestJun 29, 2018
* 3.4:  [HttpFoundation] update phpdoc of FlashBagInterface::add()  [ProxyManagerBridge] Fix support of private services (bis)  bug#27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)  [Form] relax fixtures for forward compat  [Validator] Fix the namespace of RegexTest  [Lock] fix locale dependent test case
nicolas-grekas added a commit that referenced this pull requestJun 29, 2018
* 4.0:  [HttpFoundation] update phpdoc of FlashBagInterface::add()  [ProxyManagerBridge] Fix support of private services (bis)  bug#27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)  [Form] relax fixtures for forward compat  [Validator] Fix the namespace of RegexTest  [Lock] fix locale dependent test case
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull requestJun 29, 2018
* 4.1:  [HttpFoundation] update phpdoc of FlashBagInterface::add()  [ProxyManagerBridge] Fix support of private services (bis)  bugsymfony#27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)  [Form] relax fixtures for forward compat  [Validator] Fix the namespace of RegexTest  [Lock] fix locale dependent test case
@alexislefebvre
Copy link
Contributor

Is a new release of 2.8 scheduled? The last version doesn't contain this change.

@alexislefebvre
Copy link
Contributor

alexislefebvre commentedJul 9, 2018•
edited
Loading

@fabpot Could you please publish a new 2.8 release? The last build 2.8.42 is broken, the fix in6e5c15d is merged in 2.8 but is not released yet, it will solve this problem. Thanks.

VFertak reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@alexislefebvre@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp