NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Ignore keepQueryParams attribute when generating route redirect#27664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.1fromvudaltsov:ignore-keep-query-attribute

Jun 21, 2018

Merged

[FrameworkBundle] Ignore keepQueryParams attribute when generating route redirect#27664

nicolas-grekas merged 1 commit intosymfony:4.1fromvudaltsov:ignore-keep-query-attribute

Jun 21, 2018

Conversation

Copy link

Contributor

vudaltsov commentedJun 20, 2018

Q	A
Branch?	4.1
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Prevents keepQueryParams from appearing in query.

Ignore keepQueryParams attribute when generating route redirect.

1e10475

carsonbot added Status: Needs Review FrameworkBundle Bug labels

Jun 20, 2018

nicolas-grekas added this to the4.1 milestone

Jun 21, 2018

nicolas-grekas approved these changes

Jun 21, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 21, 2018

Copy link

Member

nicolas-grekas commentedJun 21, 2018

Thank you@vudaltsov.

nicolas-grekas merged commit1e10475 intosymfony:4.1

Jun 21, 2018

nicolas-grekas added a commit that referenced this pull request

Jun 21, 2018

bug#27664[FrameworkBundle] Ignore keepQueryParams attribute when ge…

f833167

…nerating route redirect (vudaltsov)This PR was merged into the 4.1 branch.Discussion----------[FrameworkBundle] Ignore keepQueryParams attribute when generating route redirect| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Prevents keepQueryParams from appearing in query.Commits-------1e10475 Ignore keepQueryParams attribute when generating route redirect.