Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Ensure RedisSessionHandler::updateTimestamp returns a boolean#27632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJun 18, 2018
What's the return type and value now? Any link? |
ContributorAuthor
MatTheCat commentedJun 18, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
In my case I get |
nicolas-grekas approved these changesJun 18, 2018
ContributorAuthor
MatTheCat commentedJun 19, 2018
Hoping to see this in 4.1.1 😁 |
Member
nicolas-grekas commentedJun 19, 2018
Thank you@MatTheCat. |
nicolas-grekas added a commit that referenced this pull requestJun 19, 2018
…mp returns a boolean (MatTheCat)This PR was merged into the 4.1 branch.Discussion----------[HttpFoundation] Ensure RedisSessionHandler::updateTimestamp returns a boolean| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITSince v1.1.0 predis doesn't return the result of `EXPIRE` as a boolean, thus breaking `updateTimestamp` implementation.Maybe it's worth mentioning error messages were useless here:- Symfony: `User Warning: session_write_close(): Failed to write session data with Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler handler`- PHP: `session_write_close(): Session callback expects true/false return value`Commits-------079b944 Ensure updateTimestamp returns a boolean
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Since v1.1.0 predis doesn't return the result of
EXPIREas a boolean, thus breakingupdateTimestampimplementation.Maybe it's worth mentioning error messages were useless here:
User Warning: session_write_close(): Failed to write session data with Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler handlersession_write_close(): Session callback expects true/false return value