Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator][Form] Remove BOM in some xlf files#27630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.8fromgautierderuette:3.4
Jun 19, 2018

Conversation

@gautierderuette
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

I removed first blank space from some xml files

It caused this error during cache:clear
[ERROR 4] Start tag expected, '<' not found (in n/a - line 1, column 1)

@gautierderuettegautierderuette changed the title3.4Bug during cache clearJun 18, 2018
@gautierderuettegautierderuette changed the titleBug during cache clearBug during cache:clearJun 18, 2018
@nicolas-grekas
Copy link
Member

Thank you for this PR.
By "blank space", I suppose there was aBOM before the first<?
This should be merged on branch 2.8, where the files exist also, isn't it?

@gautierderuette
Copy link
ContributorAuthor

You are right, it must be a BOM,
I hesitated to merge to 2.8 because I have never seen this error before.

@gautierderuettegautierderuette changed the base branch from3.4 to2.8June 19, 2018 07:39
@gautierderuettegautierderuette changed the base branch from2.8 to3.4June 19, 2018 07:39
@gautierderuette
Copy link
ContributorAuthor

Do I have to create a new pull request ?

@nicolas-grekasnicolas-grekas changed the titleBug during cache:clear[Validator][Form] Remove BOM in some xlf filesJun 19, 2018
@nicolas-grekas
Copy link
Member

Good catch, thanks@gautierderuette.

gautierderuette reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit0bc53d6 intosymfony:2.8Jun 19, 2018
nicolas-grekas added a commit that referenced this pull requestJun 19, 2018
…uette)This PR was submitted for the 3.4 branch but it was merged into the 2.8 branch instead (closes#27630).Discussion----------[Validator][Form] Remove BOM in some xlf files| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   || Fixed tickets | #...| License       | MIT| Doc PR        | symfony/symfony-docs#...I removed first blank space from some xml filesIt caused this error during cache:clear[ERROR 4] Start tag expected, '<' not found (in n/a - line 1, column 1)Commits-------0bc53d6 [Validator] Remove BOM in some xlf files
@nicolas-grekasnicolas-grekas added this to the2.8 milestoneJun 19, 2018
This was referencedJun 25, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

3 participants

@gautierderuette@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp