Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Framework][Workflow] Added support for interfaces#27596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ->validate() | ||
| ->ifTrue(function ($v) {return !class_exists($v); }) | ||
| ->ifTrue(function ($v) {return !class_exists($v) && !interface_exists($v); }) | ||
| ->thenInvalid('The supported class %s does not exist.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The supported class or interface %s does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@lyrixx , thanx, fixed
fabpot commentedJun 15, 2018
Thank you@vudaltsov. |
…sov)This PR was squashed before being merged into the 3.4 branch (closes#27596).Discussion----------[Framework][Workflow] Added support for interfaces| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITI consider this to be a bugfix in config, because `ClassInstanceSupportStrategy` (`InstanceOfSupportStrategy`) actually works with interfaces. Therefore propose to 3.4.Commits-------6104c28 [Framework][Workflow] Added support for interfaces
I consider this to be a bugfix in config, because
ClassInstanceSupportStrategy(InstanceOfSupportStrategy) actually works with interfaces. Therefore propose to 3.4.