Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyAccess] Add Property Path to Exception Message#27586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ro0NL approved these changesJun 13, 2018
nicolas-grekas approved these changesJun 14, 2018
fabpot approved these changesJun 25, 2018
Member
fabpot commentedJun 25, 2018
Thank you@rodnaph. |
fabpot added a commit that referenced this pull requestJun 25, 2018
…e (rodnaph)This PR was merged into the 4.2-dev branch.Discussion----------[PropertyAccess] Add Property Path to Exception Message| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | None| License | MIT| Doc PR | NoneWhen an exception is thrown writing a property it is not currently obvious which path is at fault (eg. `Expected argument of type "%s", "%s" given` - but where?). This patch appends the current property path to the exception so it is clear which path caused the error (eg. `Expected argument of type "%s", "%s" given at property path "foo.bar"`)Commits-------473a025 add property path to exception message when error writing property
xabbuh added a commit to opensoftwareconsulting/rich-model-forms-bundle that referenced this pull requestAug 24, 2018
This PR was merged into the 0.1-dev branch.Discussion----------relax assertion on exception for forward compatseesymfony/symfony#27586Commits-------13414e2 relax assertion on exception for forward compat
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an exception is thrown writing a property it is not currently obvious which path is at fault (eg.
Expected argument of type "%s", "%s" given- but where?). This patch appends the current property path to the exception so it is clear which path caused the error (eg.Expected argument of type "%s", "%s" given at property path "foo.bar")